Skip to main content

keep fiddling with thumbnails

ID
a8a3eec
date
2023-06-08 09:07:55+00:00
author
Alex Chan <alex@alexwlchan.net>
parent
0b97a84
message
keep fiddling with thumbnails
changed files
3 files, 10 additions, 7 deletions

Changed files

BlinkReviewer/BlinkReviewer/Views/PhotoReviewer.swift (2003) → BlinkReviewer/BlinkReviewer/Views/PhotoReviewer.swift (1950)

diff --git a/BlinkReviewer/BlinkReviewer/Views/PhotoReviewer.swift b/BlinkReviewer/BlinkReviewer/Views/PhotoReviewer.swift
index 0020a0a..68e8b67 100644
--- a/BlinkReviewer/BlinkReviewer/Views/PhotoReviewer.swift
+++ b/BlinkReviewer/BlinkReviewer/Views/PhotoReviewer.swift
@@ -25,7 +25,10 @@ struct PhotoReviewer: View {
                     }.padding()
                 }.frame(height: 100)
                     .onChange(of: selectedAssetIndex, perform: { newIndex in
-                        proxy.scrollTo(assets[newIndex].localIdentifier, anchor: .center)
+                        withAnimation {
+                            proxy.scrollTo(assets[newIndex].localIdentifier, anchor: .center)
+                        }
+                        
                     })
             }
             Divider()
@@ -35,11 +38,7 @@ struct PhotoReviewer: View {
             Spacer()
         }.onAppear {
             NSEvent.addLocalMonitorForEvents(matching: .keyDown) { event in
-                
-                print("about to handle event \(event)")
                 handleKeyEvent(event)
-                print("finished handling event \(event)")
-                
                 return event
             }
         }

BlinkReviewer/BlinkReviewer/Views/PreviewImage.swift (3893) → BlinkReviewer/BlinkReviewer/Views/PreviewImage.swift (3933)

diff --git a/BlinkReviewer/BlinkReviewer/Views/PreviewImage.swift b/BlinkReviewer/BlinkReviewer/Views/PreviewImage.swift
index 4c2e095..3c84d55 100644
--- a/BlinkReviewer/BlinkReviewer/Views/PreviewImage.swift
+++ b/BlinkReviewer/BlinkReviewer/Views/PreviewImage.swift
@@ -14,6 +14,8 @@ extension PHAsset {
         // by Francois Nadeau: https://stackoverflow.com/a/48755517/1558022
 
         let options = PHImageRequestOptions()
+        
+        // do I still need this?
         options.isSynchronous = true
 
         // If i don't set this value, then sometimes I get an error like
@@ -33,7 +35,7 @@ extension PHAsset {
         PHCachingImageManager()
             .requestImage(
                 for: self,
-                targetSize: CGSize(width: 140, height: 140),
+                targetSize: CGSize(width: 70, height: 70),
                 contentMode: .aspectFill,
                 options: options,
                 resultHandler: { (result, info) -> Void in

BlinkReviewer/BlinkReviewer/Views/ThumbnailItem.swift (833) → BlinkReviewer/BlinkReviewer/Views/ThumbnailItem.swift (867)

diff --git a/BlinkReviewer/BlinkReviewer/Views/ThumbnailItem.swift b/BlinkReviewer/BlinkReviewer/Views/ThumbnailItem.swift
index 8ac3db1..9eadad8 100644
--- a/BlinkReviewer/BlinkReviewer/Views/ThumbnailItem.swift
+++ b/BlinkReviewer/BlinkReviewer/Views/ThumbnailItem.swift
@@ -20,8 +20,10 @@ struct ThumbnailItem: View {
             .resizable()
             // Note: order of properties is important, frame before aspectRatio otherwise breaks!
             // only in running app, not SwiftUI preview \_/
+            .scaledToFill()
             .frame(width: size, height: size, alignment: .center)
-            .aspectRatio(contentMode: .fill)
+            .clipped()
+            .border(.green)
     }
 }